codeant-ai-for-open-source[bot] commented on PR #37022: URL: https://github.com/apache/superset/pull/37022#issuecomment-3730634674
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/37022/files#diff-b715705f6513bebab92543e3c1ac44438d7213b3b81da82b648879a62b4673c1R38-R42'><strong>Pointer events / interactivity risk</strong></a><br>The combination of `enterable: true` and `pointer-events:auto` on the tooltip DOM allows pointer capture by the tooltip (intended to enable internal scrolling), but it can also block pointer events to elements behind the tooltip or interfere with chart interactions in edge cases. Verify interactions for charts that rely on pointer move events and ensure mouseleave is reliably triggered.<br> - [ ] <a href='https://github.com/apache/superset/pull/37022/files#diff-b715705f6513bebab92543e3c1ac44438d7213b3b81da82b648879a62b4673c1R42-R52'><strong>Positioning vs max-height mismatch</strong></a><br>The tooltip positioning code uses the measured `sizes.contentSize[1]` as `tooltipHeight`, but the tooltip is given `max-height:80vh` via inline CSS. If contentSize exceeds 80vh the computed tooltipHeight may not match the actual rendered/clamped height, producing incorrect on-screen placement. Consider clamping the height used in positioning to the 80vh value.<br> - [ ] <a href='https://github.com/apache/superset/pull/37022/files#diff-b715705f6513bebab92543e3c1ac44438d7213b3b81da82b648879a62b4673c1R30-R32'><strong>Large hardcoded z-index</strong></a><br>The tooltip z-index is set to an extremely large hardcoded value (2147483647). This may create unexpected stacking context issues, conflict with other overlays, and makes theming or per-page adjustments harder. Consider making the z-index configurable or moving it to stylesheet with a sensible default.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
