michael-s-molina commented on issue #37016: URL: https://github.com/apache/superset/issues/37016#issuecomment-3738703297
Love this as well. Great SIP @EnxDev! Some initial thoughts for your consideration: - Perhaps we could consider renaming “sidebar” to “rightSidebar” or even “leftSidebar,” especially with the introduction of AI Chat. What do you think? - Regarding homepage customization, do we know yet if this will be per user, or more of an admin feature that impacts all users? If possible, could we clarify this in the SIP? - I found the Configuration Storage section a little unclear. Would it be possible to provide some additional details or clarification there? - The “Toward a Generic Page Builder” section could fit within the Migration Plan and Compatibility section. - It might be challenging to support both the current homepage implementation and an alternative one in parallel. For SQL Lab, we made the default implementation rely on built-in extensions and avoided a gradual rollout. Perhaps we could take a similar approach here, using the `ENABLE_EXTENSIONS` feature flag to control external extensions. We might need a small adjustment so that built-in extensions are always available—what do you think? - We need to add `@apache-superset/core` to the dependencies list. - For "Phase 2: Extract common layout engine", I noticed it's listed as a second phase, but there are also endpoints proposed to control the layout. I wonder if we’re thinking of the same thing here. Maybe we could sync up to clarify? We would love if you can join one of our Extensions meeting (public meeting available on Superset's calendar) to talk about this SIP and discuss some of the open questions. Recently, @betodealmeida joined and we had a very inspiring meeting about [[SIP-182] Semantic Layer Support in Apache Superset](https://github.com/apache/superset/issues/35003). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
