EnxDev commented on issue #37016:
URL: https://github.com/apache/superset/issues/37016#issuecomment-3760933154
> * Perhaps we could consider renaming “sidebar” to “rightSidebar” or even
“leftSidebar,” especially with the introduction of AI Chat. What do you think?
Agreed! I'll rename `sidebar` to `leftSidebar` to align with potential AI
Chat placement and maintain consistency.
> * Regarding homepage customization, do we know yet if this will be per
user, or more of an admin feature that impacts all users? If possible, could we
clarify this in the SIP?
I'll clarify this. The intent is:
- Admins configure global/role defaults
- User customization is optional (controlled by admin setting)
- If user customization is disabled, all users see admin-defined layout
> * I found the Configuration Storage section a little unclear. Would it be
possible to provide some additional details or clarification there?
“Do you like the idea of storing pre-built pages and switching between them
via a selector?
Do you think it’s useful given our considerations?
If so, I’ll try to clarify this functionality in the SIP
> * The “Toward a Generic Page Builder” section could fit within the
Migration Plan and Compatibility section.
Makes sense to move it to Migration Plan section.
> * It might be challenging to support both the current homepage
implementation and an alternative one in parallel. For SQL Lab, we made the
default implementation rely on built-in extensions and avoided a gradual
rollout. Perhaps we could take a similar approach here, using the
`ENABLE_EXTENSIONS` feature flag to control external extensions. We might need
a small adjustment so that built-in extensions are always available—what do you
think?
I agree
> * We need to add `@apache-superset/core` to the dependencies list.
ok
> * For "Phase 2: Extract common layout engine", I noticed it's listed as a
second phase, but there are also endpoints proposed to control the layout. I
wonder if we’re thinking of the same thing here. Maybe we could sync up to
clarify?
You're right to flag this. Looking at it now, the phased approach in my
SIP assumed we'd build Homepage-specific infrastructure first, then
generalize it.
But given the Generic Page Builder direction, that distinction doesn't
make sense anymore. The layout engine and endpoints should be designed
as shared infrastructure from the start; Homepage would simply be the
first use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
