ramiroaquinoromero commented on code in PR #36996:
URL: https://github.com/apache/superset/pull/36996#discussion_r2680802074
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -354,12 +354,11 @@ export default function DateFilterLabel(props:
DateFilterControlProps) {
defaultOpen={show}
open={show}
onOpenChange={toggleOverlay}
- overlayStyle={{ width: '600px' }}
+ overlayStyle={{ width: '600px', zIndex: 1050 }}
Review Comment:
Hi @msyavuz Good morning. Based on my research I found the main reason for
this issue and this is a brief explanation about that.
**Issue:**
We had a problem where "out-of-scope" filters in vertical mode had their
date picker modals cut off (clipped) inside the Collapse panel. This happened
because those filters were incorrectly being flagged as "overflowed," which
caused the modal to render inside the panel's DOM tree and inherit its overflow
styles.
**Fix:**
I updated the logic so that in vertical orientation, out-of-scope filters
are no longer marked as overflowed. This ensures their date pickers still
render to document.body, preventing the clipping. Horizontal mode behavior
stays the same since those filters truly live in an overflow dropdown, they
still need the parent container.
Please review it. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
