msyavuz commented on code in PR #36996:
URL: https://github.com/apache/superset/pull/36996#discussion_r2676968103
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -354,12 +354,11 @@ export default function DateFilterLabel(props:
DateFilterControlProps) {
defaultOpen={show}
open={show}
onOpenChange={toggleOverlay}
- overlayStyle={{ width: '600px' }}
+ overlayStyle={{ width: '600px', zIndex: 1050 }}
Review Comment:
Custom hard coded z-index is almost definitely a symptom of something else
being wrong. Can we investigate a bit more see where we are breaking Ant
Design's z indexing?
##########
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx:
##########
@@ -354,12 +354,11 @@ export default function DateFilterLabel(props:
DateFilterControlProps) {
defaultOpen={show}
open={show}
onOpenChange={toggleOverlay}
- overlayStyle={{ width: '600px' }}
+ overlayStyle={{ width: '600px', zIndex: 1050 }}
destroyTooltipOnHide
- getPopupContainer={nodeTrigger =>
- isOverflowingFilterBar
- ? (nodeTrigger.parentNode as HTMLElement)
- : document.body
+ getPopupContainer={() =>
+ // Use document.body to prevent modal from being hidden by collapsed
panels
+ document.body
Review Comment:
I think this would impact keyboard navigation without additional props. Can
we check if that's the case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
