amaannawab923 commented on code in PR #37072:
URL: https://github.com/apache/superset/pull/37072#discussion_r2693088227
##########
superset-frontend/plugins/plugin-chart-ag-grid-table/src/transformProps.ts:
##########
@@ -474,6 +472,15 @@ const transformProps = (
theme,
} = chartProps;
+ // Merge extra_form_data (dashboard filter overrides) into formData
+ // This ensures dashboard-level settings (like time_compare) override
chart-level settings
+ // From PRs #33947 and #34014
+ const formData = merge(
+ {},
+ originalFormData,
+ originalFormData.extra_form_data,
+ );
Review Comment:
This follows the same pattern used in the regular Table plugin
(`transformProps.ts:475-479`):
```typescript
const formData = merge(
{},
originalFormData,
originalFormData.extra_form_data,
);
```
The duplication is intentional - it allows `extra_form_data` properties
(dashboard-level overrides) to take precedence over chart-level settings while
preserving the original structure. This pattern was introduced in PRs #33947
and #34014 for the regular Table plugin, and we're following the same approach
here for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
