amaannawab923 commented on code in PR #37072:
URL: https://github.com/apache/superset/pull/37072#discussion_r2693088623
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx:
##########
@@ -497,7 +497,7 @@ test('deletes a filter including dependencies', async () =>
{
}),
),
);
-});
+}, 30000);
Review Comment:
You're right - this is unrelated to the Time Shift feature. During
development, CI was consistently failing on this test due to timeout issues. I
tried rebasing with master multiple times, but the test kept failing. It's an
async test with multiple user interactions that was hitting the default 20s
timeout.
I added the 30s timeout as a temporary fix to get CI passing (matching the
pattern of the test above it at line 461 which also has a 30s timeout).
Happy to remove this change from this PR and create a separate one for the
flaky test fix if you prefer. Let me know!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
