qf-jonathan commented on code in PR #37208:
URL: https://github.com/apache/superset/pull/37208#discussion_r2701759961
##########
superset-frontend/plugins/plugin-chart-echarts/test/Heatmap/transformProps.test.ts:
##########
@@ -291,4 +291,56 @@ describe('Heatmap transformProps', () => {
// Y-axis: numbers sorted numerically (1, 2, 10 NOT 1, 10, 2)
expect(yAxisData).toEqual([1, 2, 10]);
});
+
+ test('should include rank as 4th dimension when normalized is true', () => {
+ const dataWithRank = [
+ { day_of_week: 'Monday', hour: 9, count: 10, rank: 0.33 },
+ { day_of_week: 'Monday', hour: 14, count: 15, rank: 0.67 },
+ { day_of_week: 'Wednesday', hour: 11, count: 8, rank: 0.17 },
+ { day_of_week: 'Friday', hour: 16, count: 20, rank: 1.0 },
+ ];
+
+ const chartProps = createChartProps({ normalized: true }, dataWithRank);
+
Review Comment:
This is irrelevant for this specific unit test. We're not rendering the
Heatmap; we're only verifying that the fourth dimension is present in
`series.data` when `normalized = true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
