eschutho commented on code in PR #37208:
URL: https://github.com/apache/superset/pull/37208#discussion_r2702990980
##########
superset-frontend/plugins/plugin-chart-echarts/src/Heatmap/transformProps.ts:
##########
@@ -291,8 +292,13 @@ export default function transformProps(
);
return [];
}
- return [[xIndex, yIndex, metricValue] as [number, number, any]];
- }),
+ // Include rank as 4th dimension when normalized is enabled
+ // This allows visualMap to use dimension: 3 to color by rank
percentile
+ if (normalized) {
Review Comment:
We already handle missing xIndex/yIndex by logging a warning and skipping
the row rather than breaking the chart. (see line 308) Should we take a similar
approach here for missing rankValue? E.g., log a warning and fall back to
metric coloring (visualMap.dimension = 2) instead of letting normalization
produce a broken heatmap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
