ruhz3 opened a new issue, #37258:
URL: https://github.com/apache/superset/issues/37258

   ### Bug description
   
   ## Summary
   
   The Helm chart sets `SQLALCHEMY_TRACK_MODIFICATIONS = True`, which 
introduces unnecessary performance overhead and is not used by Superset.
   
   ## Problem
   
   In `helm/superset/templates/_helpers.tpl`:
   
   ```python
   SQLALCHEMY_TRACK_MODIFICATIONS = True
   ````
   
   This option:
   
   * Adds overhead to every DB session (per Flask-SQLAlchemy docs)
   * Is inconsistent with Superset’s main configuration
   * Is not required, as Superset does not use Flask-SQLAlchemy signals
   
   ## Evidence
   
   * Superset main config explicitly disables it:
   
     ```python
     # superset/config.py
     SQLALCHEMY_TRACK_MODIFICATIONS = False
     ```
   * No usage of `models_committed` / `before_models_committed`
   * Superset relies on SQLAlchemy ORM events instead
   
   ## Proposed Change
   
   Remove the following line from `_helpers.tpl`:
   
   ```diff
   -SQLALCHEMY_TRACK_MODIFICATIONS = True
   ```
   
   ## Why this is safe
   
   * Default is `False` in recent Flask-SQLAlchemy
   * Superset already sets it to `False`
   * No dependent code paths
   * Users can still override via `configOverrides` if needed
   
   ## Impacted Versions
   
   All Helm chart versions
   
   
   ### Screenshots/recordings
   
   _No response_
   
   ### Superset version
   
   master / latest-dev
   
   ### Python version
   
   Not applicable
   
   ### Node version
   
   Not applicable
   
   ### Browser
   
   Not applicable
   
   ### Additional context
   
   _No response_
   
   ### Checklist
   
   - [ ] I have searched Superset docs and Slack and didn't find a solution to 
my problem.
   - [ ] I have searched the GitHub issue tracker and didn't find a similar bug 
report.
   - [ ] I have checked Superset's logs for errors and if I found a relevant 
Python stacktrace, I included it here as text in the "additional context" 
section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to