ruhz3 opened a new pull request, #37259: URL: https://github.com/apache/superset/pull/37259
fix(helm): remove unused SQLALCHEMY_TRACK_MODIFICATIONS setting ### SUMMARY Remove `SQLALCHEMY_TRACK_MODIFICATIONS = True` from the Helm chart helpers template. This setting introduces unnecessary performance overhead and is not used by Superset. Superset’s main configuration already explicitly sets this option to `False`, and no code relies on the Flask-SQLAlchemy signals enabled by this flag. Removing it aligns the Helm chart with Superset’s default configuration and Flask-SQLAlchemy recommendations. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TESTING INSTRUCTIONS 1. Deploy Superset using the Helm chart before and after this change. 2. Verify Superset starts normally without configuration errors. 3. Confirm database operations (e.g. SQL Lab queries, dashboard loading) work as expected. 4. Optionally, inspect the rendered config to ensure `SQLALCHEMY_TRACK_MODIFICATIONS` is not explicitly set to `True`. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
