LuisSanchez opened a new pull request, #37260: URL: https://github.com/apache/superset/pull/37260
### SUMMARY [Dashboard] - World map won't show filter info icon when default filters are applied Indicators were only calculated when `chart.chartStatus` was 'rendered' or 'success', and the `getStatus` function required columns to be in `appliedColumns` (from query response). ### Solution Indicators can be calculated when `dataMask` has values for filters targeting the chart, regardless of chart status. The `getStatus` function treats a filter as applied if it has a value and isn't rejected, even if the chart hasn't loaded yet ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF To be added ### TESTING INSTRUCTIONS 1. Navigate to FCC New Coder Survey 2018 dashboard 2. Click to edit filters 3. Select a filter to edit 4. Add a default value 5. Save 6. Notice that the filter will apply to all charts of its scope correctly, including the World map (Country of citizenship), but the filter icon will be missing for this one 7. Even if you refresh, this won't be fixed unless you add more filters, different than the default one. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: 97104 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
