bito-code-review[bot] commented on code in PR #37307: URL: https://github.com/apache/superset/pull/37307#discussion_r2714000682
########## tests/unit_tests/db_engine_specs/test_mongodb.py: ########## @@ -0,0 +1,129 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from datetime import datetime +from typing import Optional + +import pytest + +from superset.constants import TimeGrain +from tests.unit_tests.db_engine_specs.utils import assert_convert_dttm +from tests.unit_tests.fixtures.common import dttm # noqa: F401 + + [email protected]( + "target_type,expected_result", + [ + ("text", "'2019-01-02 03:04:05'"), + ("TEXT", "'2019-01-02 03:04:05'"), + ("dateTime", "'2019-01-02 03:04:05'"), + ("DateTime", "'2019-01-02 03:04:05'"), + ("DATETIME", "'2019-01-02 03:04:05'"), + ("string", "'2019-01-02 03:04:05'"), + ("String", "'2019-01-02 03:04:05'"), + ("STRING", "'2019-01-02 03:04:05'"), + ("integer", None), + ("number", None), + ("unknowntype", None), + ], +) +def test_convert_dttm( + target_type: str, + expected_result: Optional[str], + dttm: datetime, # noqa: F811 +) -> None: + """Test datetime conversion for various MongoDB column types. + """ + from superset.db_engine_specs.mongodb import ( + MongoDBEngineSpec as spec, # noqa: N813 + ) + + assert_convert_dttm(spec, target_type, expected_result, dttm) + + +def test_epoch_to_dttm() -> None: + """Test epoch to datetime conversion.""" + from superset.db_engine_specs.mongodb import ( + MongoDBEngineSpec as spec, # noqa: N813 + ) + + # MongoDB engine just passes through the column expression + assert spec.epoch_to_dttm() == "{col}" + + [email protected]( + "grain,expected_expression", + [ + (None, "{col}"), + (TimeGrain.SECOND, "DATETIME(STRFTIME('%Y-%m-%dT%H:%M:%S', {col}))"), + (TimeGrain.MINUTE, "DATETIME(STRFTIME('%Y-%m-%dT%H:%M:00', {col}))"), + (TimeGrain.HOUR, "DATETIME(STRFTIME('%Y-%m-%dT%H:00:00', {col}))"), + (TimeGrain.DAY, "DATETIME({col}, 'start of day')"), + ( + TimeGrain.WEEK, + "DATETIME({col}, 'start of day', " + "-strftime('%w', {col}) || ' days')", Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Test expectation mismatch</b></div> <div id="fix"> The formatting added spaces inside the string literal, which changes the expected test result. The actual MongoDB expression for WEEK doesn't include spaces before '-strftime', so this could cause the test to fail. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion ( TimeGrain.WEEK, "DATETIME({col}, 'start of day', " "-strftime('%w', {col}) || ' days')", ), ```` </div> </details> </div> <small><i>Code Review Run #c91ae0</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
