bito-code-review[bot] commented on code in PR #37368: URL: https://github.com/apache/superset/pull/37368#discussion_r2718385511
########## tests/unit_tests/db_engine_specs/test_mongodb.py: ########## @@ -0,0 +1,128 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from datetime import datetime +from typing import Optional + +import pytest + +from superset.constants import TimeGrain +from tests.unit_tests.db_engine_specs.utils import assert_convert_dttm +from tests.unit_tests.fixtures.common import dttm # noqa: F401 + + [email protected]( + "target_type,expected_result", + [ + ("text", "'2019-01-02 03:04:05'"), + ("TEXT", "'2019-01-02 03:04:05'"), + ("dateTime", "'2019-01-02 03:04:05'"), + ("DateTime", "'2019-01-02 03:04:05'"), + ("DATETIME", "'2019-01-02 03:04:05'"), + ("string", "'2019-01-02 03:04:05'"), + ("String", "'2019-01-02 03:04:05'"), + ("STRING", "'2019-01-02 03:04:05'"), + ("integer", None), + ("number", None), + ("unknowntype", None), + ], +) +def test_convert_dttm( + target_type: str, + expected_result: Optional[str], + dttm: datetime, # noqa: F811 +) -> None: + """Test datetime conversion for various MongoDB column types. + """ + from superset.db_engine_specs.mongodb import ( + MongoDBEngineSpec as spec, # noqa: N813 + ) + + assert_convert_dttm(spec, target_type, expected_result, dttm) + + +def test_epoch_to_dttm() -> None: + """Test epoch to datetime conversion.""" + from superset.db_engine_specs.mongodb import ( + MongoDBEngineSpec as spec, # noqa: N813 + ) + + # MongoDB engine just passes through the column expression + assert spec.epoch_to_dttm() == "{col}" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect test expectation for epoch conversion</b></div> <div id="fix"> The test expects epoch_to_dttm() to return "{col}", but the implementation returns "datetime({col}, 'unixepoch')", which will cause this assertion to fail. It looks like the test comment assumes pass-through behavior, but the code uses SQLite-style datetime conversion for PyMongoSQL compatibility. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- a/tests/unit_tests/db_engine_specs/test_mongodb.py +++ b/tests/unit_tests/db_engine_specs/test_mongodb.py @@ -63,7 +63,7 @@ def test_epoch_to_dttm() -> None: # MongoDB engine just passes through the column expression assert spec.epoch_to_dttm() == "{col}" + assert spec.epoch_to_dttm() == "datetime({col}, 'unixepoch')" ``` </div> </details> </div> <small><i>Code Review Run #53b056</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## tests/unit_tests/db_engine_specs/test_mongodb.py: ########## @@ -0,0 +1,128 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from datetime import datetime +from typing import Optional + +import pytest + +from superset.constants import TimeGrain +from tests.unit_tests.db_engine_specs.utils import assert_convert_dttm +from tests.unit_tests.fixtures.common import dttm # noqa: F401 + + [email protected]( + "target_type,expected_result", + [ + ("text", "'2019-01-02 03:04:05'"), + ("TEXT", "'2019-01-02 03:04:05'"), + ("dateTime", "'2019-01-02 03:04:05'"), + ("DateTime", "'2019-01-02 03:04:05'"), + ("DATETIME", "'2019-01-02 03:04:05'"), + ("string", "'2019-01-02 03:04:05'"), + ("String", "'2019-01-02 03:04:05'"), + ("STRING", "'2019-01-02 03:04:05'"), + ("integer", None), + ("number", None), + ("unknowntype", None), + ], +) +def test_convert_dttm( + target_type: str, + expected_result: Optional[str], + dttm: datetime, # noqa: F811 +) -> None: + """Test datetime conversion for various MongoDB column types. + """ + from superset.db_engine_specs.mongodb import ( + MongoDBEngineSpec as spec, # noqa: N813 + ) + + assert_convert_dttm(spec, target_type, expected_result, dttm) + + +def test_epoch_to_dttm() -> None: + """Test epoch to datetime conversion.""" + from superset.db_engine_specs.mongodb import ( + MongoDBEngineSpec as spec, # noqa: N813 + ) + + # MongoDB engine just passes through the column expression + assert spec.epoch_to_dttm() == "{col}" + + [email protected]( + "grain,expected_expression", + [ + (None, "{col}"), + (TimeGrain.SECOND, "DATETIME(STRFTIME('%Y-%m-%dT%H:%M:%S', {col}))"), + (TimeGrain.MINUTE, "DATETIME(STRFTIME('%Y-%m-%dT%H:%M:00', {col}))"), + (TimeGrain.HOUR, "DATETIME(STRFTIME('%Y-%m-%dT%H:00:00', {col}))"), + (TimeGrain.DAY, "DATETIME({col}, 'start of day')"), + ( + TimeGrain.WEEK, + "DATETIME({col}, 'start of day', " + "-strftime('%w', {col}) || ' days')", + ), + (TimeGrain.MONTH, "DATETIME({col}, 'start of month')"), + ( + TimeGrain.QUARTER, + "DATETIME({col}, 'start of month', " + "printf('-%d month', (strftime('%m', {col}) - 1) % 3))", + ), + (TimeGrain.YEAR, "DATETIME({col}, 'start of year')"), + ( + TimeGrain.WEEK_ENDING_SATURDAY, + "DATETIME({col}, 'start of day', 'weekday 6')", + ), + ( + TimeGrain.WEEK_ENDING_SUNDAY, + "DATETIME({col}, 'start of day', 'weekday 0')", + ), + ( + TimeGrain.WEEK_STARTING_SUNDAY, + "DATETIME({col}, 'start of day', 'weekday 0', '-7 days')", + ), Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Wrong expected SQL for week starting Sunday</b></div> <div id="fix"> The test expects a different SQL expression for WEEK_STARTING_SUNDAY than what's in the implementation, which will cause assertion failure. The code uses -strftime('%w', {col}) || ' days' to adjust to Sunday start, but the test has 'weekday 0', '-7 days' which would go to the previous Sunday. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- a/tests/unit_tests/db_engine_specs/test_mongodb.py +++ b/tests/unit_tests/db_engine_specs/test_mongodb.py @@ -96,8 +96,7 @@ ( TimeGrain.WEEK_STARTING_SUNDAY, - "DATETIME({col}, 'start of day', 'weekday 0', '-7 days')", + "DATETIME({col}, 'start of day', -strftime('%w', {col}) || ' days')", ), ``` </div> </details> </div> <small><i>Code Review Run #53b056</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/db_engine_specs/mongodb.py: ########## @@ -0,0 +1,112 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""MongoDB engine spec for Superset. + +Uses PyMongoSQL (https://github.com/passren/PyMongoSQL) as the SQLAlchemy dialect +to enable SQL queries on MongoDB collections. +""" + +from __future__ import annotations + +from datetime import datetime +from typing import Any, Optional + +from sqlalchemy import types + +from superset.constants import TimeGrain +from superset.db_engine_specs.base import BaseEngineSpec, DatabaseCategory + + +class MongoDBEngineSpec(BaseEngineSpec): + """Engine spec for MongoDB using PyMongoSQL dialect.""" + + engine = "mongodb" + engine_name = "MongoDB" + force_column_alias_quotes = False + + metadata = { + "description": ( + "MongoDB is a document-oriented, operational NoSQL database." + ), + "logo": "mongodb.png", + "homepage_url": "https://www.mongodb.com/";, + "categories": [ + DatabaseCategory.SEARCH_NOSQL, + DatabaseCategory.PROPRIETARY, + ], + "pypi_packages": ["pymongosql"], + "connection_string": ( + "mongodb://{username}:{password}@{host}:{port}/{database}?mode=superset" + ), + "parameters": { + "username": "Username for MongoDB", + "password": "Password for MongoDB", + "host": "MongoDB host", + "port": "MongoDB port", + "database": "Database name", + }, + "notes": "Uses PartiQL for SQL queries. Requires mode=superset parameter.", + "docs_url": "https://github.com/passren/PyMongoSQL";, + } + + _time_grain_expressions = { + None: "{col}", + TimeGrain.SECOND: "DATETIME(STRFTIME('%Y-%m-%dT%H:%M:%S', {col}))", + TimeGrain.MINUTE: "DATETIME(STRFTIME('%Y-%m-%dT%H:%M:00', {col}))", + TimeGrain.HOUR: "DATETIME(STRFTIME('%Y-%m-%dT%H:00:00', {col}))", + TimeGrain.DAY: "DATETIME({col}, 'start of day')", + TimeGrain.WEEK: ( + "DATETIME({col}, 'start of day', " + "-strftime('%w', {col}) || ' days')" + ), + TimeGrain.MONTH: "DATETIME({col}, 'start of month')", + TimeGrain.QUARTER: ( + "DATETIME({col}, 'start of month', " + "printf('-%d month', (strftime('%m', {col}) - 1) % 3))" + ), + TimeGrain.YEAR: "DATETIME({col}, 'start of year')", + TimeGrain.WEEK_ENDING_SATURDAY: "DATETIME({col}, 'start of day', 'weekday 6')", + TimeGrain.WEEK_ENDING_SUNDAY: "DATETIME({col}, 'start of day', 'weekday 0')", + TimeGrain.WEEK_STARTING_SUNDAY: ( + "DATETIME({col}, 'start of day', -strftime('%w', {col}) || ' days')" + ), + TimeGrain.WEEK_STARTING_MONDAY: ( + "DATETIME({col}, 'start of day', " + "'-' || ((strftime('%w', {col}) + 6) % 7) || ' days')" + ), + } + + @classmethod + def epoch_to_dttm(cls) -> str: + return "datetime({col}, 'unixepoch')" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect epoch conversion</b></div> <div id="fix"> The epoch_to_dttm method returns a SQLite-style expression, but the test expects a pass-through of the column for MongoDB. Update to return "{col}" as MongoDB handles epoch conversion differently. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- superset/db_engine_specs/mongodb.py +++ superset/db_engine_specs/mongodb.py @@ -94,2 +94,2 @@ - @classmethod - def epoch_to_dttm(cls) -> str: - return "datetime({col}, 'unixepoch')" + @classmethod + def epoch_to_dttm(cls) -> str: + return "{col}" ``` </div> </details> </div> <small><i>Code Review Run #53b056</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/db_engine_specs/mongodb.py: ########## @@ -0,0 +1,112 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""MongoDB engine spec for Superset. + +Uses PyMongoSQL (https://github.com/passren/PyMongoSQL) as the SQLAlchemy dialect +to enable SQL queries on MongoDB collections. +""" + +from __future__ import annotations + +from datetime import datetime +from typing import Any, Optional + +from sqlalchemy import types + +from superset.constants import TimeGrain +from superset.db_engine_specs.base import BaseEngineSpec, DatabaseCategory + + +class MongoDBEngineSpec(BaseEngineSpec): + """Engine spec for MongoDB using PyMongoSQL dialect.""" + + engine = "mongodb" + engine_name = "MongoDB" + force_column_alias_quotes = False + + metadata = { + "description": ( + "MongoDB is a document-oriented, operational NoSQL database." + ), + "logo": "mongodb.png", + "homepage_url": "https://www.mongodb.com/";, + "categories": [ + DatabaseCategory.SEARCH_NOSQL, + DatabaseCategory.PROPRIETARY, + ], + "pypi_packages": ["pymongosql"], + "connection_string": ( + "mongodb://{username}:{password}@{host}:{port}/{database}?mode=superset" + ), + "parameters": { + "username": "Username for MongoDB", + "password": "Password for MongoDB", + "host": "MongoDB host", + "port": "MongoDB port", + "database": "Database name", + }, + "notes": "Uses PartiQL for SQL queries. Requires mode=superset parameter.", + "docs_url": "https://github.com/passren/PyMongoSQL";, + } + + _time_grain_expressions = { + None: "{col}", + TimeGrain.SECOND: "DATETIME(STRFTIME('%Y-%m-%dT%H:%M:%S', {col}))", + TimeGrain.MINUTE: "DATETIME(STRFTIME('%Y-%m-%dT%H:%M:00', {col}))", + TimeGrain.HOUR: "DATETIME(STRFTIME('%Y-%m-%dT%H:00:00', {col}))", + TimeGrain.DAY: "DATETIME({col}, 'start of day')", + TimeGrain.WEEK: ( + "DATETIME({col}, 'start of day', " + "-strftime('%w', {col}) || ' days')" + ), + TimeGrain.MONTH: "DATETIME({col}, 'start of month')", + TimeGrain.QUARTER: ( + "DATETIME({col}, 'start of month', " + "printf('-%d month', (strftime('%m', {col}) - 1) % 3))" + ), + TimeGrain.YEAR: "DATETIME({col}, 'start of year')", + TimeGrain.WEEK_ENDING_SATURDAY: "DATETIME({col}, 'start of day', 'weekday 6')", + TimeGrain.WEEK_ENDING_SUNDAY: "DATETIME({col}, 'start of day', 'weekday 0')", + TimeGrain.WEEK_STARTING_SUNDAY: ( + "DATETIME({col}, 'start of day', -strftime('%w', {col}) || ' days')" + ), + TimeGrain.WEEK_STARTING_MONDAY: ( + "DATETIME({col}, 'start of day', " + "'-' || ((strftime('%w', {col}) + 6) % 7) || ' days')" + ), Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Wrong week start expression</b></div> <div id="fix"> The WEEK_STARTING_MONDAY time grain expression does not match the test expectation. Update to the expected expression for correct week start calculation. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- superset/db_engine_specs/mongodb.py +++ superset/db_engine_specs/mongodb.py @@ -87,4 +87,2 @@ - TimeGrain.WEEK_STARTING_MONDAY: ( - "DATETIME({col}, 'start of day', " - "'-' || ((strftime('%w', {col}) + 6) % 7) || ' days')" - ), + TimeGrain.WEEK_STARTING_MONDAY: "DATETIME({col}, 'start of day', 'weekday 1', '-7 days')", ``` </div> </details> </div> <small><i>Code Review Run #53b056</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/db_engine_specs/mongodb.py: ########## @@ -0,0 +1,112 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""MongoDB engine spec for Superset. + +Uses PyMongoSQL (https://github.com/passren/PyMongoSQL) as the SQLAlchemy dialect +to enable SQL queries on MongoDB collections. +""" + +from __future__ import annotations + +from datetime import datetime +from typing import Any, Optional + +from sqlalchemy import types + +from superset.constants import TimeGrain +from superset.db_engine_specs.base import BaseEngineSpec, DatabaseCategory + + +class MongoDBEngineSpec(BaseEngineSpec): + """Engine spec for MongoDB using PyMongoSQL dialect.""" + + engine = "mongodb" + engine_name = "MongoDB" + force_column_alias_quotes = False + + metadata = { + "description": ( + "MongoDB is a document-oriented, operational NoSQL database." + ), + "logo": "mongodb.png", + "homepage_url": "https://www.mongodb.com/";, + "categories": [ + DatabaseCategory.SEARCH_NOSQL, + DatabaseCategory.PROPRIETARY, + ], + "pypi_packages": ["pymongosql"], + "connection_string": ( + "mongodb://{username}:{password}@{host}:{port}/{database}?mode=superset" + ), + "parameters": { + "username": "Username for MongoDB", + "password": "Password for MongoDB", + "host": "MongoDB host", + "port": "MongoDB port", + "database": "Database name", + }, + "notes": "Uses PartiQL for SQL queries. Requires mode=superset parameter.", + "docs_url": "https://github.com/passren/PyMongoSQL";, + } + + _time_grain_expressions = { + None: "{col}", + TimeGrain.SECOND: "DATETIME(STRFTIME('%Y-%m-%dT%H:%M:%S', {col}))", + TimeGrain.MINUTE: "DATETIME(STRFTIME('%Y-%m-%dT%H:%M:00', {col}))", + TimeGrain.HOUR: "DATETIME(STRFTIME('%Y-%m-%dT%H:00:00', {col}))", + TimeGrain.DAY: "DATETIME({col}, 'start of day')", + TimeGrain.WEEK: ( + "DATETIME({col}, 'start of day', " + "-strftime('%w', {col}) || ' days')" + ), + TimeGrain.MONTH: "DATETIME({col}, 'start of month')", + TimeGrain.QUARTER: ( + "DATETIME({col}, 'start of month', " + "printf('-%d month', (strftime('%m', {col}) - 1) % 3))" + ), + TimeGrain.YEAR: "DATETIME({col}, 'start of year')", + TimeGrain.WEEK_ENDING_SATURDAY: "DATETIME({col}, 'start of day', 'weekday 6')", + TimeGrain.WEEK_ENDING_SUNDAY: "DATETIME({col}, 'start of day', 'weekday 0')", + TimeGrain.WEEK_STARTING_SUNDAY: ( + "DATETIME({col}, 'start of day', -strftime('%w', {col}) || ' days')" + ), Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Wrong week start expression</b></div> <div id="fix"> The WEEK_STARTING_SUNDAY time grain expression does not match the test expectation. Update to the expected SQLite-style expression for correct week start calculation. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- superset/db_engine_specs/mongodb.py +++ superset/db_engine_specs/mongodb.py @@ -82,2 +82,2 @@ - TimeGrain.WEEK_STARTING_SUNDAY: ( - "DATETIME({col}, 'start of day', -strftime('%w', {col}) || ' days')" - ), + TimeGrain.WEEK_STARTING_SUNDAY: "DATETIME({col}, 'start of day', 'weekday 0', '-7 days')", ``` </div> </details> </div> <small><i>Code Review Run #53b056</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## tests/unit_tests/db_engine_specs/test_mongodb.py: ########## @@ -0,0 +1,128 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from datetime import datetime +from typing import Optional + +import pytest + +from superset.constants import TimeGrain +from tests.unit_tests.db_engine_specs.utils import assert_convert_dttm +from tests.unit_tests.fixtures.common import dttm # noqa: F401 + + [email protected]( + "target_type,expected_result", + [ + ("text", "'2019-01-02 03:04:05'"), + ("TEXT", "'2019-01-02 03:04:05'"), + ("dateTime", "'2019-01-02 03:04:05'"), + ("DateTime", "'2019-01-02 03:04:05'"), + ("DATETIME", "'2019-01-02 03:04:05'"), + ("string", "'2019-01-02 03:04:05'"), + ("String", "'2019-01-02 03:04:05'"), + ("STRING", "'2019-01-02 03:04:05'"), + ("integer", None), + ("number", None), + ("unknowntype", None), + ], +) +def test_convert_dttm( + target_type: str, + expected_result: Optional[str], + dttm: datetime, # noqa: F811 +) -> None: + """Test datetime conversion for various MongoDB column types. + """ + from superset.db_engine_specs.mongodb import ( + MongoDBEngineSpec as spec, # noqa: N813 + ) + + assert_convert_dttm(spec, target_type, expected_result, dttm) + + +def test_epoch_to_dttm() -> None: + """Test epoch to datetime conversion.""" + from superset.db_engine_specs.mongodb import ( + MongoDBEngineSpec as spec, # noqa: N813 + ) + + # MongoDB engine just passes through the column expression + assert spec.epoch_to_dttm() == "{col}" + + [email protected]( + "grain,expected_expression", + [ + (None, "{col}"), + (TimeGrain.SECOND, "DATETIME(STRFTIME('%Y-%m-%dT%H:%M:%S', {col}))"), + (TimeGrain.MINUTE, "DATETIME(STRFTIME('%Y-%m-%dT%H:%M:00', {col}))"), + (TimeGrain.HOUR, "DATETIME(STRFTIME('%Y-%m-%dT%H:00:00', {col}))"), + (TimeGrain.DAY, "DATETIME({col}, 'start of day')"), + ( + TimeGrain.WEEK, + "DATETIME({col}, 'start of day', " + "-strftime('%w', {col}) || ' days')", + ), + (TimeGrain.MONTH, "DATETIME({col}, 'start of month')"), + ( + TimeGrain.QUARTER, + "DATETIME({col}, 'start of month', " + "printf('-%d month', (strftime('%m', {col}) - 1) % 3))", + ), + (TimeGrain.YEAR, "DATETIME({col}, 'start of year')"), + ( + TimeGrain.WEEK_ENDING_SATURDAY, + "DATETIME({col}, 'start of day', 'weekday 6')", + ), + ( + TimeGrain.WEEK_ENDING_SUNDAY, + "DATETIME({col}, 'start of day', 'weekday 0')", + ), + ( + TimeGrain.WEEK_STARTING_SUNDAY, + "DATETIME({col}, 'start of day', 'weekday 0', '-7 days')", + ), + ( + TimeGrain.WEEK_STARTING_MONDAY, + "DATETIME({col}, 'start of day', 'weekday 1', '-7 days')", + ), Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Wrong expected SQL for week starting Monday</b></div> <div id="fix"> The expected SQL for WEEK_STARTING_MONDAY doesn't match the code's expression, leading to test failure. The implementation uses a calculation to adjust to Monday start, but the test has 'weekday 1', '-7 days' which shifts to the prior Monday. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- a/tests/unit_tests/db_engine_specs/test_mongodb.py +++ b/tests/unit_tests/db_engine_specs/test_mongodb.py @@ -100,8 +100,7 @@ ( TimeGrain.WEEK_STARTING_MONDAY, - "DATETIME({col}, 'start of day', 'weekday 1', '-7 days')", + "DATETIME({col}, 'start of day', '-' || ((strftime('%w', {col}) + 6) % 7) || ' days')", ), ``` </div> </details> </div> <small><i>Code Review Run #53b056</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
