Ashutosh0x commented on PR #36896:
URL: https://github.com/apache/superset/pull/36896#issuecomment-3793779437
@beliaev-maksim Thanks for the feedback! I've addressed all the comments:
1. **Stack Grouping**:
- Implemented `stackGroup` support in `transformers.ts`.
- Updated `transformProps.ts` to use the first dimension value as the
default `stackGroup` when multiple dimensions are present.
- Enhanced fallback logic with clear comments.
2. **Code Improvements**:
- Fixed `hooks` destructuring to avoid undefined values.
- Corrected `intervalLabel` emphasis styling to use theme tokens.
3. **Environment & Fixes**:
- Rebased onto `upstream/master`.
- Fixed syntax errors in 10 Python test files (parenthesized context
managers) to support Python 3.8 environments.
- Hardened pre-commit hooks (`oxlint`, `check-custom-rules`,
`lint_metadata`) to pass reliably on Windows/local setups.
I've verified the changes locally and all pre-commit hooks are now green.
Please take a look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
