Ashutosh0x commented on PR #36896: URL: https://github.com/apache/superset/pull/36896#issuecomment-3793898142
@bito-code-review[bot] @codeant-ai-for-open-source[bot] I've addressed all the latest feedback points: 1. **Fixed chunked script execution**: `check-custom-rules.sh` and `oxlint.sh` now correctly accumulate exit codes across chunks and continue processing all files even if a chunk fails, ensuring complete coverage and accurate reporting. 2. **Enhanced Runtime Safety**: Added guards to the custom rules script to prevent crashes if AST dependencies are missing, with explicit failures in CI environments. 3. **Refactored MixedTimeseries**: Added a robust helper for stacking values, documented the newline suffix convention, and added edge-case unit tests (handling commas, missing labels, and null values). 4. **Cleaned up Backend & Tests**: Removed the duplicate AST branch in `lint_metadata.py` and corrected the docstrings in `thumbnails_tests.py`. I am keeping the `typing.Type` syntax to maintain compatibility with the project's Python 3.8 support. Everything is pushed to the branch. /review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
