michael-s-molina commented on code in PR #37411:
URL: https://github.com/apache/superset/pull/37411#discussion_r2727479207
##########
superset/sql/execution/executor.py:
##########
@@ -460,6 +460,16 @@ def _check_security(self, script: SQLScript) -> None:
)
)
+ # Check disallowed tables
+ if disallowed_tables := self._check_disallowed_tables(script):
Review Comment:
Maybe rename `disallowed` to `disallowed_functions` now that we have 2 types?
##########
superset/config.py:
##########
@@ -1800,6 +1800,34 @@ def engine_context_manager( # pylint:
disable=unused-argument
},
}
+# Per-engine blocklist of system catalog tables/views that should not be
queried.
+# Prevents information disclosure through system catalog access.
+DISALLOWED_SQL_TABLES: dict[str, set[str]] = {
Review Comment:
cc @dpgaspar @betodealmeida
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
