bito-code-review[bot] commented on PR #37433: URL: https://github.com/apache/superset/pull/37433#issuecomment-3801068352
<!-- Bito Reply --> The logic for checking actual column types is being added to the Superset codebase in this PR via the `is_column_truly_temporal` function in `chart_utils.py`. It bypasses name-based heuristics to prevent DATE_TRUNC failures on non-temporal columns. If you're suggesting it should reside in core Superset rather than the MCP service, that could improve reusability, but the current placement supports the MCP tools directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
