geido commented on code in PR #37433:
URL: https://github.com/apache/superset/pull/37433#discussion_r2728751203
##########
superset/mcp_service/chart/chart_utils.py:
##########
@@ -92,27 +95,102 @@ def generate_explore_link(dataset_id: int | str,
form_data: Dict[str, Any]) -> s
# Return URL with just the form_data_key
return f"{base_url}/explore/?form_data_key={form_data_key}"
- except Exception:
+ except (CommandException, SQLAlchemyError, ValueError, AttributeError):
# Fallback to basic explore URL with numeric ID if available
if numeric_dataset_id is not None:
return (
f"{base_url}/explore/?datasource_type=table"
f"&datasource_id={numeric_dataset_id}"
)
+ return
f"{base_url}/explore/?datasource_type=table&datasource_id={dataset_id}"
+
+
+def is_column_truly_temporal(column_name: str, dataset_id: int | str | None)
-> bool:
Review Comment:
I find this surprising. Should this logic of checking the actual type live
in the Superset codebase so that the type is not inferred solely from the name
heuristics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
