bito-code-review[bot] commented on code in PR #37458: URL: https://github.com/apache/superset/pull/37458#discussion_r2729735825
########## superset/translations/it/LC_MESSAGES/messages.po: ########## @@ -10464,7 +10464,7 @@ msgstr "%s - senza nome" msgid "Subtitle Font Size" msgstr "Grandezza della bolla" -msgid "Subtotal" +msgid "Subvalue" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Italian translation for Subvalue</b></div> <div id="fix"> The msgid has been updated from 'Subtotal' to 'Subvalue' to match the string used in the code (e.g., in superset/charts/client_processing.py), but the msgstr remains empty. This could result in untranslated 'Subvalue' appearing in the UI for Italian users. Please add the appropriate Italian translation. </div> </div> <small><i>Code Review Run #6b3610</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/uk/LC_MESSAGES/messages.po: ########## @@ -10555,7 +10555,7 @@ msgstr "Назва вкладки" msgid "Subtitle Font Size" msgstr "Розмір міхура" -msgid "Subtotal" +msgid "Subvalue" msgstr "Суттєвий" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect translation for subtotal</b></div> <div id="fix"> The msgid changed from "Subtotal" to "Subvalue", but the msgstr remained "Суттєвий" (meaning "significant"). In pivot table context, "Subvalue" refers to subtotal labels, which should be "підсумок" in Ukrainian, as confirmed by standard translations and other languages like French ("Sous-total"). </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion msgid "Subvalue" msgstr "підсумок" ```` </div> </details> </div> <small><i>Code Review Run #6b3610</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/en/LC_MESSAGES/messages.po: ########## @@ -9682,7 +9682,7 @@ msgstr "" msgid "Subtitle Font Size" msgstr "" -msgid "Subtotal" +msgid "Subvalue" msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect subtotal translation</b></div> <div id="fix"> The msgid was updated to "Subvalue", but the msgstr remains empty, causing pivot table subtotals to display as "Subvalue" instead of the correct "Subtotal". This affects user-facing labels in `superset/charts/client_processing.py` and `superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx`. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ````suggestion msgstr "Subtotal" ```` </div> </details> </div> <small><i>Code Review Run #6b3610</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh_TW/LC_MESSAGES/messages.po: ########## @@ -10509,7 +10509,7 @@ msgstr "選項卡標題" msgid "Subtitle Font Size" msgstr "氣泡尺寸" -msgid "Subtotal" +msgid "Subvalue" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing translation for Subvalue</b></div> <div id="fix"> The msgid has been changed from 'Subtotal' to 'Subvalue', but the msgstr remains empty. This will display 'Subvalue' to zh_TW users instead of a translated string. Please provide an appropriate translation. </div> </div> <small><i>Code Review Run #6b3610</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
