ramiroaquinoromero opened a new pull request, #37479:
URL: https://github.com/apache/superset/pull/37479
## SUMMARY
Enables the "Select All" button for dashboard native filters when
"Dynamically search all filter values" is enabled.
#### **The Change**
``` typescript
// Before
allowSelectAll={!searchAllOptions} // Disabled when dynamic search was on
// After
allowSelectAll={multiSelect} // Enabled for all multi-select filters
```
#### **Why This Works**
The Select component already handles "Select All" intelligently:
- When you search and click "Select All" → it selects only the
visible/filtered results
- When you don't search and click "Select All" → it selects all available
options
This works the same way whether the filter uses dynamic search (backend
filtering) or static search (frontend filtering). The component already had
this logic - we just needed to stop disabling the button.
### BEFORE/AFTER
**BEFORE**: No "Select All"/"Deselect All" buttons when "Dynamically search
all filter values" enabled
**AFTER**: Buttons visible and functional for all multi-select filters
### TESTING INSTRUCTIONS
1. Create a dashboard filter with "Dynamically search all filter values"
enabled
2. Open the filter dropdown → Verify "Select All" button appears
3. Type a search term → Click "Select All" → Verify only matching values are
selected
4. Deselect one value → Verify it's removed
5. Click "Deselect All" → Verify all cleared
6. Test non-dynamic filter → Verify "Select All" still works (regression
check)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
