ramiroaquinoromero commented on PR #37479: URL: https://github.com/apache/superset/pull/37479#issuecomment-3804816888
> This becomes a problem after 1k rows on the select. Before and after doesn't show that but if you have more than 1k rows 'Select all' would display the 1000 after a while. Thanks for catching this @msyavuz! You're absolutely right - I didn't consider the case where there are more than 1,000 rows. Currently, clicking "Select all" would only select the first 1,000 visible options, which is misleading. I see two potential approaches to fix this: Option 1: Disable "Select All" when data is truncated We could hide the "Select All" button when searchAllOptions is enabled and we've hit the 1,000 row limit. This would prevent users from thinking they're selecting all values when they're only getting a subset. It's the safest approach but less functional - users lose the convenience of selecting all visible options. Option 2: Leverage inverse selection mode Since we already have inverse selection support (inverseSelection), we could make "Select All" with dynamic search automatically switch to inverse mode. This would work like: User clicks "Select All" → switches to "all values EXCEPT..." mode User can then deselect specific values they don't want The query would use NOT IN instead of IN, so it truly selects all possible values This approach is more powerful but requires careful UX consideration - we'd need to make it clear that the mode switched, maybe with a toast notification or visual indicator. What do you think? I'm leaning toward Option 1 for simplicity and to avoid confusion, but Option 2 would be more feature-complete. Happy to implement whichever approach the team prefers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
