semohr commented on PR #37461: URL: https://github.com/apache/superset/pull/37461#issuecomment-3804065564
Hey, quick FYI, I added support for the same feature as in #37396 for *Explore* (not *Drill*) a few days before your changes. I took a brief look at your implementation and I’m not sure relying solely on `label_map` is sufficient, since it sometimes misses labels defined at the dataset level. In my testing, the label map occasionally didn’t include the `verbose_name` coming from the backend. This is my first deeper dive into Superset internals, so I may be missing some context as well. That said, it might be worth aligning our efforts and reusing the newly proposed `collabels` data (from my PR) here too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
