bito-code-review[bot] commented on code in PR #37461:
URL: https://github.com/apache/superset/pull/37461#discussion_r2730294706
##########
superset-frontend/packages/superset-ui-core/src/query/types/QueryResponse.ts:
##########
@@ -50,6 +50,7 @@ export interface ChartDataResponseResult {
* Name of each column, for retaining the order of the output columns.
*/
colnames: string[];
+ label_map: Record<string, string[]>;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Interface optionality mismatch</b></div>
<div id="fix">
The label_map field is used in the codebase with optional access (e.g.,
queryData.label_map?.[k] and { label_map = {} }), but the interface declares it
as required. This mismatch could cause TypeScript inconsistencies.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
label_map?: Record<string, string[]>;
````
</div>
</details>
</div>
<small><i>Code Review Run #1244e6</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
