rusackas commented on PR #37407: URL: https://github.com/apache/superset/pull/37407#issuecomment-3807345560
## Bot Comment Assessment Reviewed the automated review comments on this PR. Here's a summary of relevance: ### Copilot Comment #1 — String conversion concern **Low relevance.** The existing dimension-based cross-filter code already converts values to strings (e.g., `String(...)` is used throughout the codebase for filter values). This follows the established pattern. ### Copilot Comments #2 & #3 — Undefined check on `props.data[0]` **Valid minor improvement.** The code checks `props.data` for truthiness but doesn't guard against an empty array, so `props.data[0]` could be `undefined`. In practice this is unlikely to cause issues (an empty-data chart wouldn't fire click/context-menu events on data points), but adding `props.data?.[0]` would be a defensive improvement. ### Copilot Comment #4 — Visual feedback mismatch with `selectedValues` **Valid and important.** This is a real concern. When cross-filtering by X-axis value, `selectedValues` will contain X-axis values (e.g., `"Product A"`). However, `transformers.ts` line 241 checks `!filterState?.selectedValues.includes(name)` where `name` is the **series name** (e.g., `"Sales"`). Since X-axis values won't match series names, all series will appear dimmed — the visual highlight feedback won't work correctly for X-axis cross-filtering. This would need a fix in the opacity/highlight logic in `transformers.ts` to distinguish between dimension-based filtering (matches series names) and X-axis filtering (matches data point X values). ### bito-code-review bot **No actionable items** — generic summary, no specific concerns raised. ### netlify bot **Standard deploy preview link** — not a review comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
