rusackas commented on code in PR #37407:
URL: https://github.com/apache/superset/pull/37407#discussion_r2737540455
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -419,6 +419,7 @@ export default function transformProps(
timeCompare: array,
timeShiftColor,
theme,
+ hasDimensions: groupBy.length > 0,
Review Comment:
Done! Added optional chaining in commit 7b808a4. Note: I kept using
`groupBy` (the ensured array from `ensureIsArray(groupby)`) rather than the raw
`groupby` prop, since `groupBy` is guaranteed to be an array. The optional
chaining provides extra defensive safety.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
