rusackas opened a new pull request, #37500: URL: https://github.com/apache/superset/pull/37500
### SUMMARY Two issues with the README database logos section: 1. **Identicon logos**: `cratedb.png` and `risingwave.png` were GitHub default identicon avatars (colored pixel patterns), not actual database logos. These were introduced in #36805 when the auto-generation script sourced incorrect images. 2. **No deduplication**: The README generator (`generateReadmeLogos()`) listed all databases with logos without deduplicating by filename. The docs homepage (`index.tsx`) already deduplicates using a `Set<string>` on logo filenames, but the README script didn't, causing 4 duplicate logos. **Fixes:** - Replaced identicon PNGs with real SVG logos sourced from the official [CrateDB](https://github.com/crate/crate) and [RisingWave](https://github.com/risingwavelabs/risingwave) GitHub repos - Updated engine spec `metadata` in `crate.py` and `risingwave.py` to reference `.svg` files - Updated `databases.json` to match - Added deduplication + `homepage_url` filter to `generateReadmeLogos()` matching the docs homepage logic - Removed 4 duplicate entries: Databricks Interactive Cluster (same logo as Apache Hive), IBM Db2 for i (same as IBM Db2), MySQL (same as Aurora MySQL), PostgreSQL (same as Aurora PostgreSQL) README now shows **61 unique database logos**, matching the docs homepage exactly. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **Before**: CrateDB and RisingWave showed as GitHub identicon avatars; 65 entries with duplicates **After**: Real logos; 61 unique entries matching docs homepage ### TESTING INSTRUCTIONS 1. View the README on GitHub and confirm all database logos render correctly 2. Confirm no identicon/pixel-pattern images remain 3. Compare with the [docs homepage database wall](https://superset.apache.org/) — should show the same set of logos 4. Optionally regenerate: `cd docs && npm run update:readme-db-logos` — should produce no diff ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
