bito-code-review[bot] commented on code in PR #37500:
URL: https://github.com/apache/superset/pull/37500#discussion_r2734866425
##########
.rat-excludes:
##########
@@ -67,20 +67,8 @@ temporary_superset_ui/*
# skip license checks for auto-generated test snapshots
.*snap
-# docs overrides for third party logos we don't have the rights to
-google-big-query.svg
-google-sheets.svg
-ibm-db2.svg
-netlify.png
-postgresql.svg
-snowflake.svg
-ydb.svg
-loading.svg
-apache-solr.svg
-azure.svg
-superset.svg
-
-# docs third-party logos, i.e. docs/static/img/logos/*
+# docs third-party logos (database logos, org logos, etc.)
+databases/*
logos/*
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect RAT exclude patterns</b></div>
<div id="fix">
The patterns 'databases/*' and 'logos/*' do not match files in
docs/static/img/databases/ and docs/static/img/logos/ since RAT matches against
full paths. This will cause RAT to check third-party logos for license headers,
leading to failures as images lack headers. Use full paths with ** for
recursive exclusion.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
docs/static/img/databases/**
docs/static/img/logos/**
````
</div>
</details>
</div>
<small><i>Code Review Run #136549</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
