FelipeGLopez commented on code in PR #37218:
URL: https://github.com/apache/superset/pull/37218#discussion_r2743236967
##########
superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx:
##########
@@ -419,14 +420,15 @@ const config: ControlPanelConfig = {
freeForm: true,
label: t('Row limit'),
clearable: false,
- mapStateToProps: state => ({
+ mapStateToProps: (state, controlState) => ({
+ value: controlState?.value ?? 10000,
Review Comment:
I found this issue
[here](https://github.com/apache/superset/pull/37218/changes#diff-e07e5c8190a73296c5a8192ac79a72cfe9eb1e93a076a4511b8879131c54a669R125-R126)
with undefined & null. Also, there was another `default` prop outside the
config in a json called `override` that in this particular case didn't have any
effect. I deleted it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
