bito-code-review[bot] commented on PR #37405:
URL: https://github.com/apache/superset/pull/37405#issuecomment-3822828153

   <!-- Bito Reply -->
   To check if the code is using colorScaleKey or seriesKey, consider modifying 
the mock to capture calls and assert on the parameters. This ensures the color 
logic depends on the key.
   
   
**superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformers.test.ts**
   ```
   const mockColorScale = jest.fn((key: string, sliceId?: number) => 
`color-for-${key}-${sliceId}`);
   // In test:
   expect(mockColorScale).toHaveBeenCalledWith(expectedKey, expectedSliceId);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to