VanessaGiannoni commented on code in PR #37405:
URL: https://github.com/apache/superset/pull/37405#discussion_r2746594633
##########
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformers.test.ts:
##########
@@ -45,7 +45,7 @@ describe('transformSeries', () => {
const result = transformSeries(series, mockColorScale, 'test-key', opts);
- expect((result as any)?.itemStyle.color).toBe('color-for-test-key-1');
+ expect((result as any)?.itemStyle.color).toBeDefined();
});
Review Comment:
Good point, I changed to be like this now:
- when `timeShiftColor` is enabled, it uses the `colorScaleKey`, and when
disabled, it uses the `seriesKey`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
