bito-code-review[bot] commented on code in PR #37488: URL: https://github.com/apache/superset/pull/37488#discussion_r2752015959
########## superset-frontend/src/views/store.ts: ########## @@ -37,7 +37,7 @@ import sliceEntities from 'src/dashboard/reducers/sliceEntities'; import dashboardLayout from 'src/dashboard/reducers/undoableDashboardLayout'; import logger from 'src/middleware/loggerMiddleware'; import saveModal from 'src/explore/reducers/saveModalReducer'; -import explore from 'src/explore/reducers/exploreReducer'; +import explore from 'src/explore/reducers/undoableExploreReducer'; Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Redux-undo filter bug risk</b></div> <div id="fix"> Switching to undoableExploreReducer adds undo functionality to explore state, but the current implementation uses redux-undo's includeAction filter which is buggy in version ^1.0.0-beta9-9-7. This may cause incorrect undo history tracking for SET_FIELD_VALUE and UPDATE_CHART_TITLE actions. Consider using the same wrapper approach as undoableDashboardLayout to ensure reliable filtering. </div> </div> <small><i>Code Review Run #035687</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
