msyavuz commented on code in PR #37488:
URL: https://github.com/apache/superset/pull/37488#discussion_r2753433455
##########
superset-frontend/src/components/Chart/ChartRenderer.jsx:
##########
@@ -181,14 +165,9 @@ class ChartRenderer extends Component {
nextProps.triggerRender ||
nextProps.labelsColor !== this.props.labelsColor ||
nextProps.labelsColorMap !== this.props.labelsColorMap ||
- nextProps.formData.color_scheme !== this.props.formData.color_scheme ||
- nextProps.formData.stack !== this.props.formData.stack ||
- nextProps.formData.subcategories !==
Review Comment:
These checks are a subset of the new isEqual check for formData. Are we sure
new version doesn't cause false negatives?
##########
superset-frontend/src/components/Chart/ChartRenderer.jsx:
##########
@@ -153,26 +153,10 @@ class ChartRenderer extends Component {
this.mutableQueriesResponse = cloneDeep(nextProps.queriesResponse);
}
- // Check if any matrixify-related properties have changed
- const hasMatrixifyChanges = () => {
- const isMatrixifyEnabled =
- nextProps.formData.matrixify_enable_vertical_layout === true ||
- nextProps.formData.matrixify_enable_horizontal_layout === true;
- if (!isMatrixifyEnabled) return false;
-
- // Check all matrixify-related properties
- const matrixifyKeys = Object.keys(nextProps.formData).filter(key =>
- key.startsWith('matrixify_'),
- );
-
- return matrixifyKeys.some(
- key => !isEqual(nextProps.formData[key], this.props.formData[key]),
- );
- };
Review Comment:
Why are we removing this check and subsequent condition that depends on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
