villebro commented on PR #36368: URL: https://github.com/apache/superset/pull/36368#issuecomment-3873275911
> Sounds reasonable. Main thing I'm slightly worried about is multiple execution paths for extended periods of time on the repo. Would love to have all tasks go through the same general codepaths/decorators/abstractions, even if some tasks don't provide the same guarantees (dedup on/off, database tracking on/off, ...). Doesn't have to be in this PR necessarily. Not sure how complex that would be either, would have to spend more time reviewing, but some sort of `@global_task_framework(mode="legacy")` decorator to wire all async/celery task could be nice, even if some modes/configs are no-op for now. The majority of logic should be shared. I'll be updating the actual functional code to have optional abort handlers that will simply be undefined for the legacy paths. But I'll give it another go when this is merged and I start working in earnest on the first migration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
