rusackas commented on PR #36732: URL: https://github.com/apache/superset/pull/36732#issuecomment-3876250037
@Facyla thanks for the PR... it's a reasonable feature. Sorry the bot comments get overwhelming sometimes, but you can mark them as resolved or comment on them if they're irrelevant. It helps us reviewers, and they find legit things ALL THE TIME :D I know this is a pain to keep the PR up to snuff (it needs a rebase again in fact, since everything is FINALLY typescript. I'm happy to try to get this rebased and take/reject some bot comments if you want. As for the general approach, we have a handful of general visualizations that have threshold-based coloring with UI rather than json editing. @SBIN2010 has worked on some of that and might be able to help us here as well. Let me know if you think it's worth tackling some UI to set thresholds and apply colors. I think it'd be really cool! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
