rusackas commented on PR #36732: URL: https://github.com/apache/superset/pull/36732#issuecomment-3931002509
I think the UI looks good! My only suggestion is to NOT merge it as-is if the improvement is to be made... otherwise, as soon as someone used the JSON control, you're on the hook to do DB migrations when the controls are added... which can get intricate/painful to prevent a "breaking change" there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
