sadpandajoe opened a new pull request, #37866: URL: https://github.com/apache/superset/pull/37866
### SUMMARY Adds Playwright E2E tests for the Chart List page, migrating coverage from Cypress. This PR introduces 5 test cases covering chart CRUD operations with both UI and backend API verification. **New files (5):** - `playwright/helpers/api/chart.ts` — Chart API helpers (CRUD + getByName), following the dataset.ts pattern - `playwright/pages/ChartListPage.ts` — Page object composing Table + BulkSelect components - `playwright/components/modals/ChartPropertiesModal.ts` — Properties edit modal (extends Modal base) - `playwright/tests/experimental/chart/chart-test-helpers.ts` — `createTestChart()` factory using members_channels_2 dataset - `playwright/tests/experimental/chart/chart-list.spec.ts` — 5 E2E tests **Modified files (1):** - `playwright/helpers/fixtures/testAssets.ts` — Added `trackChart()` with chart cleanup (respects FK order: charts → datasets → databases) **Tests:** | Test | Description | |------|-------------| | delete chart with confirmation | Single chart delete via action button + DELETE modal | | edit chart name via properties modal | Edit name through properties modal, verify via API | | export chart as zip file | Single chart export, validates zip structure | | bulk delete multiple charts | Bulk select 2 charts, delete, verify 404s | | bulk export multiple charts | Bulk select 2 charts, export, validate zip with 2+ charts | All tests create data via API, perform UI actions, and verify both UI state and backend API responses. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — test-only changes ### TESTING INSTRUCTIONS ```bash cd superset-frontend INCLUDE_EXPERIMENTAL=true npx playwright test playwright/tests/experimental/chart/chart-list.spec.ts ``` Requires a running Superset instance with `--load-examples`. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
