sadpandajoe commented on code in PR #37866: URL: https://github.com/apache/superset/pull/37866#discussion_r2790966369
########## superset-frontend/playwright/helpers/api/chart.ts: ########## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { Page, APIResponse } from '@playwright/test'; +import { + apiGet, + apiPost, + apiDelete, + apiPut, + ApiRequestOptions, +} from './requests'; + +export const ENDPOINTS = { + CHART: 'api/v1/chart/', + CHART_EXPORT: 'api/v1/chart/export/', +} as const; + Review Comment: Good catch — `getChartByName` was removed in round 2 (b273c2d) since it was unused. Updated the PR description to say "CRUD" instead of "CRUD + getByName". ########## superset-frontend/playwright/helpers/api/assertions.ts: ########## @@ -59,3 +60,60 @@ export function expectStatusOneOf<T extends ResponseLike>( ).toContain(response.status()); return response; } + +interface ExportZipOptions { + /** Directory name containing resource yaml files (e.g. 'charts', 'datasets') */ + resourceDir: string; + /** Minimum number of resource yaml files expected (default: 1) */ + minCount?: number; + /** Regex to validate Content-Disposition header (skipped if omitted) */ + contentDispositionPattern?: RegExp; + /** Resource names that must each appear in at least one YAML filepath */ + expectedNames?: string[]; +} + +/** + * Validate an export zip response: content-type, zip structure, and resource yaml files. + * Shared across chart and dataset export tests. + */ +export async function expectValidExportZip( + response: Response, Review Comment: Agreed — both `Response` and `APIResponse` have compatible `.headers()` and `.body()` signatures. Widened to `ResponseLike` for consistency with `expectStatus*` helpers in the same file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
