aminghadersohi commented on PR #36933: URL: https://github.com/apache/superset/pull/36933#issuecomment-3886515888
Re: modal prop naming - The `show` and `onHide` props are correct according to the Modal component API in `superset-ui-core/components/Modal/types.ts`. Other modals in the same file (e.g., DrillDetailModal) also use `show`, not `showModal`. This comment appears to be a false positive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
