aminghadersohi commented on code in PR #36933:
URL: https://github.com/apache/superset/pull/36933#discussion_r2795376159
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -603,6 +618,13 @@ const SliceHeaderControls = (
dataset={datasetWithVerboseMap}
/>
+ <EmbeddedChartModal
+ chartId={slice.slice_id}
+ formData={props.formData}
+ show={embedModalIsOpen}
+ onHide={() => setEmbedModalIsOpen(false)}
Review Comment:
This is not a bug. The `EmbeddedChartModal` component correctly accepts
`show` and `onHide` props (defined in Props interface at
superset-frontend/src/dashboard/components/EmbeddedChartModal/index.tsx:37-42)
and passes them to the Modal component (lines 281-282). The Modal component
from @superset-ui/core/components uses `show` and `onHide` as its interface,
not `showModal` and `onHideModal`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
