bito-code-review[bot] commented on code in PR #37906:
URL: https://github.com/apache/superset/pull/37906#discussion_r2799730435
##########
superset/datasets/schemas.py:
##########
@@ -414,6 +414,7 @@ class DatasetColumnDrillInfoSchema(Schema):
class UserSchema(Schema):
first_name = fields.String()
last_name = fields.String()
+ email = fields.String()
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>API Response Field Change</b></div>
<div id="fix">
This changes the UserSchema from serializing 'username' to 'email', which
alters the JSON response for the dataset drill_info API. User objects in
'owners', 'created_by', and 'changed_by' will now include 'email' instead of
'username'. While this makes datasets consistent with charts, it may break
clients expecting 'username'. The security API still uses 'username', so
consider standardizing all UserSchemas.
</div>
</div>
<small><i>Code Review Run #17ab66</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
