bito-code-review[bot] commented on code in PR #37906:
URL: https://github.com/apache/superset/pull/37906#discussion_r2799860830
##########
superset/datasets/schemas.py:
##########
@@ -414,6 +414,7 @@ class DatasetColumnDrillInfoSchema(Schema):
class UserSchema(Schema):
first_name = fields.String()
last_name = fields.String()
+ email = fields.String()
Review Comment:
<!-- Bito Reply -->
No, the suggestion isn’t fully correct — the diff adds an email field to the
UserSchema in superset/datasets/schemas.py, but the original schema only
included first_name and last_name, with no username field to replace. This
makes datasets consistent with charts and reports by exposing email, but it may
not align with the PR's intent to show usernames and could break clients
expecting username data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
