bito-code-review[bot] commented on code in PR #37973:
URL: https://github.com/apache/superset/pull/37973#discussion_r2806830490
##########
requirements/base.txt:
##########
@@ -120,7 +120,7 @@ flask==2.3.3
# flask-session
# flask-sqlalchemy
# flask-wtf
-flask-appbuilder==5.0.2
+flask-appbuilder @
git+https://github.com/aminghadersohi/Flask-AppBuilder@amin/ch99414/api-key-auth
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Supply Chain Security Risk</b></div>
<div id="fix">
Switching to a git dependency from a third-party fork introduces supply
chain risks, as the branch can change unpredictably and the fork may not be
vetted. Flask-AppBuilder is central to authentication and RBAC in Superset, so
this could affect security if the fork has untrusted code. Consider using an
official release or a pinned commit instead.
</div>
</div>
<small><i>Code Review Run #b5c2de</i></small>
</div><div>
<div id="suggestion">
<div id="issue"><b>API key hashing change may invalidate existing
keys</b></div>
<div id="fix">
Updating to this commit changes API key hashing from SHA-256 to
HMAC-SHA-256, which may invalidate existing keys. Since Superset uses FAB API
keys, this could break authentication. A migration to re-hash keys might be
needed.
</div>
</div>
<small><i>Code Review Run #3665ad</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
