Antonio-RiveroMartnez commented on code in PR #37964:
URL: https://github.com/apache/superset/pull/37964#discussion_r2832650792
##########
superset/mcp_service/app.py:
##########
@@ -31,16 +31,35 @@
logger = logging.getLogger(__name__)
-def get_default_instructions(branding: str = "Apache Superset") -> str:
+def get_default_instructions(
+ branding: str = "Apache Superset",
+ unavailable_features: list[str] | None = None,
+) -> str:
"""Get default instructions with configurable branding.
Args:
branding: Product name to use in instructions
(e.g., "ACME Analytics", "Apache Superset")
+ unavailable_features: List of features not available in this deployment
+ that LLMs should not suggest to users.
Returns:
Formatted instructions string with branding applied
"""
+ unavailable_section = ""
+ if unavailable_features:
+ features_list = "\n".join(f"- {f}" for f in unavailable_features)
Review Comment:
Is there a standard way to know what these features are (all) by default?
should we have a list somewhere so we can easy to grab the name to use? Asking
because it's a string, we can pass anything (not tied to a tool name etc so
very wide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
