aminghadersohi commented on code in PR #37964:
URL: https://github.com/apache/superset/pull/37964#discussion_r2833733670
##########
superset/mcp_service/app.py:
##########
@@ -31,16 +31,35 @@
logger = logging.getLogger(__name__)
-def get_default_instructions(branding: str = "Apache Superset") -> str:
+def get_default_instructions(
+ branding: str = "Apache Superset",
+ unavailable_features: list[str] | None = None,
+) -> str:
"""Get default instructions with configurable branding.
Args:
branding: Product name to use in instructions
(e.g., "ACME Analytics", "Apache Superset")
+ unavailable_features: List of features not available in this deployment
+ that LLMs should not suggest to users.
Returns:
Formatted instructions string with branding applied
"""
+ unavailable_section = ""
+ if unavailable_features:
+ features_list = "\n".join(f"- {f}" for f in unavailable_features)
Review Comment:
Added `MCP_FEATURE_ACTION_LOG`, `MCP_FEATURE_LIST_USERS`, and
`MCP_FEATURE_LIST_ROLES` constants in `mcp_config.py` along with an
`MCP_ALL_KNOWN_FEATURES` convenience list. Deployers can now import and
reference these constants instead of guessing strings:
```python
from superset.mcp_service.mcp_config import (
MCP_FEATURE_ACTION_LOG, MCP_FEATURE_LIST_USERS, MCP_FEATURE_LIST_ROLES,
)
MCP_UNAVAILABLE_FEATURES = [MCP_FEATURE_ACTION_LOG, MCP_FEATURE_LIST_USERS,
MCP_FEATURE_LIST_ROLES]
```
Custom strings are still accepted for flexibility. We can expand the
constant catalog as we identify more deployment-specific features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
