bito-code-review[bot] commented on code in PR #37488: URL: https://github.com/apache/superset/pull/37488#discussion_r2844291308
########## superset-frontend/src/views/store.ts: ########## @@ -37,7 +37,7 @@ import sliceEntities from 'src/dashboard/reducers/sliceEntities'; import dashboardLayout from 'src/dashboard/reducers/undoableDashboardLayout'; import logger from 'src/middleware/loggerMiddleware'; import saveModal from 'src/explore/reducers/saveModalReducer'; -import explore from 'src/explore/reducers/exploreReducer'; +import explore from 'src/explore/reducers/undoableExploreReducer'; Review Comment: <!-- Bito Reply --> The explanation addresses the redux-undo filter bug concern by clarifying that issue #306 stems from incorrect action type filtering in Redux Toolkit, which doesn't apply here since the implementation uses proper action types. This suggests the wrapper approach like undoableDashboardLayout isn't necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
