pierreeurope opened a new pull request, #38258: URL: https://github.com/apache/superset/pull/38258
## SUMMARY Fixes #37444 When collapsing the Metrics section in the Data panel, the Columns section was incorrectly disappearing. The root cause was stale folder IDs persisting in the state after the folders prop changed (during search or datasource updates). ## BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF The bug is documented in issue #37444 with before/after screenshots showing that collapsing Metrics caused Columns to vanish. ## TEST PLAN 1. Open any chart in explore view 2. Collapse the Metrics section using the ^ arrow 3. Verify the Columns section remains visible and accessible 4. Try searching to filter metrics/columns and collapse/expand sections 5. Verify state management works correctly across datasource changes ## ADDITIONAL INFORMATION Added a hook that synchronizes with the current prop: - Removes folder IDs that no longer exist in the current structure - Preserves collapse state for folders that still exist - Respects default collapse states for new folders This ensures the UI state stays consistent with the data structure, preventing orphaned IDs from causing rendering issues. ## CHECKLIST - [x] Has associated issue - [x] Required approvals granted - [x] Changes have been tested locally - [x] Commits follow conventional-commits format - [x] Code follows style guidelines -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
