codeant-ai-for-open-source[bot] commented on code in PR #38033:
URL: https://github.com/apache/superset/pull/38033#discussion_r2882885293
##########
superset-frontend/src/features/home/RightMenu.tsx:
##########
@@ -503,7 +503,7 @@ const RightMenu = ({
key: 'logout',
label: (
<Typography.Link
- href={ensureAppRoot(navbarRight.user_logout_url)}
+ href={navbarRight.user_logout_url}
>
Review Comment:
**Suggestion:** The logout link uses `navbarRight.user_logout_url` directly
without `ensureAppRoot`, unlike other menu URLs, so when `SUPERSET_APP_ROOT` is
configured the logout will point to an unprefixed path and may break or route
to the wrong URL; wrapping it with `ensureAppRoot` makes the logout URL
consistent and app-root aware. [logic error]
<details>
<summary><b>Severity Level:</b> Critical 🚨</summary>
```mdx
- ❌ Logout menu broken for SUPERSET_APP_ROOT deployments.
- ⚠️ Users may remain logged in after clicking logout.
- ⚠️ Inconsistent app-root handling versus other navbar links.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
