hannespr commented on PR #38033:
URL: https://github.com/apache/superset/pull/38033#issuecomment-3986128769

   Thank you very much, @albundy83! First of all: Apologies :see_no_evil: - I 
made a mistake in my local setup with your PR - thats why the login button did 
not work.
   
   :heavy_check_mark: Login button works
   :heavy_check_mark: User Info works
   :heavy_check_mark: Logoutworks
   :red_circle: `brandLogoHref` is still prefixed with the app root, even for 
external URLs, e.g. /superset/http://... 🙈 - any idea on this?
   
   But great job, very nice!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to