lucapazz commented on code in PR #38094:
URL: https://github.com/apache/superset/pull/38094#discussion_r2883937960
##########
superset-frontend/src/visualizations/TimeTable/TimeTable.tsx:
##########
@@ -81,6 +81,12 @@ const TimeTable = ({
const valueField = row.label || row.metric_name || '';
const cellValues = columnConfigs.reduce<Record<string, ReactNode>>(
(acc, columnConfig) => {
+ const { value } = calculateCellValue(
+ valueField,
+ columnConfig,
+ reversedEntries,
+ );
Review Comment:
Hi @EnxDev! I’ve prepared some changes for that, but I haven’t pushed them
yet.
My idea is to keep the call to `calculateCellValue` in `TimeTable.tsx` and
remove it from `ValueCell.tsx`.
The cell values would then be computed only once when creating the rows, and
those values would be passed as‑is to the `ValueCell` component.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
